Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean optimization: don't evict zeros and don't scan disk for clean #2856

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HaoranYi
Copy link

@HaoranYi HaoranYi commented Sep 6, 2024

Problem

#2824 fixed orphaned ancient zero storages. But it adds more work to clean.

Optimize clean scan

Summary of Changes

  1. don't evict zeros to disk
  2. don't scan disk for clean

Fixes #

@HaoranYi HaoranYi changed the title don't evict zeros and don't scan disk for clean clean optimization: don't evict zeros and don't scan disk for clean Sep 6, 2024
@HaoranYi HaoranYi force-pushed the accounts-db/clean_opt branch from 4bdf7f0 to f5a88c7 Compare September 6, 2024 13:30
@HaoranYi HaoranYi marked this pull request as draft September 6, 2024 18:09
@HaoranYi HaoranYi force-pushed the accounts-db/clean_opt branch from f5a88c7 to 4cbe424 Compare September 6, 2024 18:11
@HaoranYi
Copy link
Author

HaoranYi commented Sep 9, 2024

This PR has been running against mainnet for 3 days.
It shows similar memory usage, more clean time???
Need more investigation on why it more time to clean...

@HaoranYi
Copy link
Author

HaoranYi commented Sep 9, 2024

scan missing metric

  • master
    image

  • This PR
    image

50K vs 10K.

40K savings for on-disk lookup per 4min! - 10K per minute

@HaoranYi
Copy link
Author

HaoranYi commented Sep 9, 2024

RAM usage: stable around 93G
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants